Skip to content

Conversation

@iliapolo
Copy link
Contributor

Appears that the underlying issue failing this test has been resolved.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@iliapolo iliapolo requested a review from a team as a code owner February 13, 2025 07:11
@aws-cdk-automation aws-cdk-automation requested a review from a team February 13, 2025 07:11
@github-actions github-actions bot added the p2 label Feb 13, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Feb 13, 2025
@aws-cdk-automation
Copy link
Collaborator

➡️ PR build request submitted to test-main-pipeline ⬅️

A maintainer must now check the pipeline and add the pr-linter/cli-integ-tested label once the pipeline succeeds.

@codecov
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.90%. Comparing base (aebb331) to head (d3de5b4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #33425   +/-   ##
=======================================
  Coverage   80.90%   80.90%           
=======================================
  Files         236      236           
  Lines       14261    14261           
  Branches     2493     2493           
=======================================
  Hits        11538    11538           
  Misses       2438     2438           
  Partials      285      285           
Flag Coverage Δ
suite.unit 80.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 79.74% <ø> (ø)
packages/aws-cdk-lib/core 82.16% <ø> (ø)

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: d3de5b4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Feb 13, 2025
@iliapolo iliapolo added the pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested label Feb 13, 2025
@iliapolo
Copy link
Contributor Author

Proof that the sam test ran and passed:

[INTEG TEST::sam can locally test the synthesized cdk application] Done (944215 ms). <------------------
[INTEG TEST::hotswap deployment for ecs service detects failed deployment and errors] Done (788022 ms).
[INTEG TEST::test resource import] Done (986222 ms).
[INTEG TEST::cdk migrate java deploys successfully] Done (1935472 ms).
PASS cli_integ/tests/cli-integ-tests/cli.integtest.js (3408.999 s)
  ● Console

    console.log
      Using regions: us-east-1,us-west-2,ca-central-1,ap-southeast-1,sa-east-1

      at log (../../lib/with-aws.ts:83:11)


Seed:        1914821188
Test Suites: 5 passed, 5 total
Tests:       139 passed, 139 total
Snapshots:   0 total
Time:        3409.187 s
Ran all test suites.

@mergify
Copy link
Contributor

mergify bot commented Feb 13, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit efb5a34 into main Feb 13, 2025
41 checks passed
@mergify mergify bot deleted the epolon/restore-sam-test branch February 13, 2025 09:44
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2025
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Feb 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2 pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants